[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 04/18] tests: print newline after QMP response in qtest logs
From: |
Daniel P . Berrangé |
Subject: |
[PATCH 04/18] tests: print newline after QMP response in qtest logs |
Date: |
Wed, 2 Mar 2022 17:49:18 +0000 |
The QMP commands have a trailing newline, but the response does not.
This makes the qtest logs hard to follow as the next QMP command
appears in the same line as the previous QMP response.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qtest/libqtest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index a85f8a6d05..79c3edcf4b 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -629,6 +629,9 @@ QDict *qmp_fd_receive(int fd)
}
json_message_parser_feed(&qmp.parser, &c, 1);
}
+ if (log) {
+ g_assert(write(2, "\n", 1) == 1);
+ }
json_message_parser_destroy(&qmp.parser);
return qmp.response;
--
2.34.1
- [PATCH 10/18] tests: switch migration FD passing test to use common precopy helper, (continued)
- [PATCH 10/18] tests: switch migration FD passing test to use common precopy helper, Daniel P . Berrangé, 2022/03/02
- [PATCH 11/18] tests: expand the migration precopy helper to support failures, Daniel P . Berrangé, 2022/03/02
- [PATCH 12/18] tests: add migration tests of TLS with PSK credentials, Daniel P . Berrangé, 2022/03/02
- [PATCH 13/18] tests: add migration tests of TLS with x509 credentials, Daniel P . Berrangé, 2022/03/02
- [PATCH 04/18] tests: print newline after QMP response in qtest logs,
Daniel P . Berrangé <=
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Peter Xu, 2022/03/07
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Daniel P . Berrangé, 2022/03/07
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Thomas Huth, 2022/03/07
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Peter Xu, 2022/03/07
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Daniel P . Berrangé, 2022/03/10
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Marc-André Lureau, 2022/03/10
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Daniel P . Berrangé, 2022/03/10
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Marc-André Lureau, 2022/03/10
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Daniel P . Berrangé, 2022/03/10
- Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs, Marc-André Lureau, 2022/03/10