Re: [PATCH 04/18] tests: print newline after QMP response in qtest logs

[Peter Xu]

On Wed, Mar 02, 2022 at 05:49:18PM +0000, Daniel P. Berrangé wrote:
> The QMP commands have a trailing newline, but the response does not.
> This makes the qtest logs hard to follow as the next QMP command
> appears in the same line as the previous QMP response.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  tests/qtest/libqtest.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
> index a85f8a6d05..79c3edcf4b 100644
> --- a/tests/qtest/libqtest.c
> +++ b/tests/qtest/libqtest.c
> @@ -629,6 +629,9 @@ QDict *qmp_fd_receive(int fd)
>          }
>          json_message_parser_feed(&qmp.parser, &c, 1);
>      }
> +    if (log) {
> +        g_assert(write(2, "\n", 1) == 1);
> +    }

Drop the g_assert() to remove side effect of G_DISABLE_ASSERT?

-- 
Peter Xu