[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 31/31] job.h: assertions in the callers of JobDriver function
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v8 31/31] job.h: assertions in the callers of JobDriver function pointers |
Date: |
Thu, 3 Mar 2022 10:16:16 -0500 |
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
job.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/job.c b/job.c
index 54db80df66..075c6f3a20 100644
--- a/job.c
+++ b/job.c
@@ -381,6 +381,8 @@ void job_ref(Job *job)
void job_unref(Job *job)
{
+ GLOBAL_STATE_CODE();
+
if (--job->refcnt == 0) {
assert(job->status == JOB_STATUS_NULL);
assert(!timer_pending(&job->sleep_timer));
@@ -602,6 +604,7 @@ bool job_user_paused(Job *job)
void job_user_resume(Job *job, Error **errp)
{
assert(job);
+ GLOBAL_STATE_CODE();
if (!job->user_paused || job->pause_count <= 0) {
error_setg(errp, "Can't resume a job that was not paused");
return;
@@ -672,6 +675,7 @@ static void job_update_rc(Job *job)
static void job_commit(Job *job)
{
assert(!job->ret);
+ GLOBAL_STATE_CODE();
if (job->driver->commit) {
job->driver->commit(job);
}
@@ -680,6 +684,7 @@ static void job_commit(Job *job)
static void job_abort(Job *job)
{
assert(job->ret);
+ GLOBAL_STATE_CODE();
if (job->driver->abort) {
job->driver->abort(job);
}
@@ -687,6 +692,7 @@ static void job_abort(Job *job)
static void job_clean(Job *job)
{
+ GLOBAL_STATE_CODE();
if (job->driver->clean) {
job->driver->clean(job);
}
@@ -726,6 +732,7 @@ static int job_finalize_single(Job *job)
static void job_cancel_async(Job *job, bool force)
{
+ GLOBAL_STATE_CODE();
if (job->driver->cancel) {
force = job->driver->cancel(job, force);
} else {
@@ -825,6 +832,7 @@ static void job_completed_txn_abort(Job *job)
static int job_prepare(Job *job)
{
+ GLOBAL_STATE_CODE();
if (job->ret == 0 && job->driver->prepare) {
job->ret = job->driver->prepare(job);
job_update_rc(job);
@@ -952,6 +960,7 @@ static void coroutine_fn job_co_entry(void *opaque)
Job *job = opaque;
assert(job && job->driver && job->driver->run);
+ assert(job->aio_context == qemu_get_current_aio_context());
job_pause_point(job);
job->ret = job->driver->run(job, &job->err);
job->deferred_to_main_loop = true;
@@ -1054,6 +1063,7 @@ void job_complete(Job *job, Error **errp)
{
/* Should not be reachable via external interface for internal jobs */
assert(job->id);
+ GLOBAL_STATE_CODE();
if (job_apply_verb(job, JOB_VERB_COMPLETE, errp)) {
return;
}
--
2.31.1
- [PATCH v8 11/31] include/block/block_int: split header into I/O and global state API, (continued)
- [PATCH v8 11/31] include/block/block_int: split header into I/O and global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 18/31] include/block/blockjob.h: global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 22/31] include/block/snapshot: global state API + assertions, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 15/31] include/block/blockjob_int.h: split header into I/O and GS API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 16/31] GS and IO CODE macros for blockjob_int.h, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 17/31] block.c: add assertions to static functions, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 20/31] include/sysemu/blockdev.h: global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 25/31] block_int-common.h: split function pointers in BlockDriver, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 27/31] block_int-common.h: split function pointers in BdrvChildClass, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 26/31] block_int-common.h: assertions in the callers of BlockDriver function pointers, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 31/31] job.h: assertions in the callers of JobDriver function pointers,
Emanuele Giuseppe Esposito <=
- [PATCH v8 19/31] assertions for blockjob.h global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 14/31] block: introduce assert_bdrv_graph_writable, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 24/31] block/coroutines: I/O and "I/O or GS" API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 29/31] block-backend-common.h: split function pointers in BlockDevOps, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 23/31] block/copy-before-write.h: global state API + assertions, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 21/31] assertions for blockdev.h global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 28/31] block_int-common.h: assertions in the callers of BdrvChildClass function pointers, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 30/31] job.h: split function pointers in JobDriver, Emanuele Giuseppe Esposito, 2022/03/03
- Re: [PATCH v8 00/31] block layer: split block APIs in global state and I/O, Kevin Wolf, 2022/03/04