[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 23/31] block/copy-before-write.h: global state API + assertion
From: |
Emanuele Giuseppe Esposito |
Subject: |
[PATCH v8 23/31] block/copy-before-write.h: global state API + assertions |
Date: |
Thu, 3 Mar 2022 10:16:08 -0500 |
copy-before-write functions always run under BQL.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
---
block/copy-before-write.c | 2 ++
block/copy-before-write.h | 7 +++++++
2 files changed, 9 insertions(+)
diff --git a/block/copy-before-write.c b/block/copy-before-write.c
index c30a5ff8de..80b7684dba 100644
--- a/block/copy-before-write.c
+++ b/block/copy-before-write.c
@@ -223,6 +223,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
QDict *opts;
assert(source->total_sectors == target->total_sectors);
+ GLOBAL_STATE_CODE();
opts = qdict_new();
qdict_put_str(opts, "driver", "copy-before-write");
@@ -245,6 +246,7 @@ BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
void bdrv_cbw_drop(BlockDriverState *bs)
{
+ GLOBAL_STATE_CODE();
bdrv_drop_filter(bs, &error_abort);
bdrv_unref(bs);
}
diff --git a/block/copy-before-write.h b/block/copy-before-write.h
index 51847e711a..6e72bb25e9 100644
--- a/block/copy-before-write.h
+++ b/block/copy-before-write.h
@@ -29,6 +29,13 @@
#include "block/block_int.h"
#include "block/block-copy.h"
+/*
+ * Global state (GS) API. These functions run under the BQL.
+ *
+ * See include/block/block-global-state.h for more information about
+ * the GS API.
+ */
+
BlockDriverState *bdrv_cbw_append(BlockDriverState *source,
BlockDriverState *target,
const char *filter_node_name,
--
2.31.1
- [PATCH v8 17/31] block.c: add assertions to static functions, (continued)
- [PATCH v8 17/31] block.c: add assertions to static functions, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 20/31] include/sysemu/blockdev.h: global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 25/31] block_int-common.h: split function pointers in BlockDriver, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 27/31] block_int-common.h: split function pointers in BdrvChildClass, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 26/31] block_int-common.h: assertions in the callers of BlockDriver function pointers, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 31/31] job.h: assertions in the callers of JobDriver function pointers, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 19/31] assertions for blockjob.h global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 14/31] block: introduce assert_bdrv_graph_writable, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 24/31] block/coroutines: I/O and "I/O or GS" API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 29/31] block-backend-common.h: split function pointers in BlockDevOps, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 23/31] block/copy-before-write.h: global state API + assertions,
Emanuele Giuseppe Esposito <=
- [PATCH v8 21/31] assertions for blockdev.h global state API, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 28/31] block_int-common.h: assertions in the callers of BdrvChildClass function pointers, Emanuele Giuseppe Esposito, 2022/03/03
- [PATCH v8 30/31] job.h: split function pointers in JobDriver, Emanuele Giuseppe Esposito, 2022/03/03
- Re: [PATCH v8 00/31] block layer: split block APIs in global state and I/O, Kevin Wolf, 2022/03/04