[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/10] macfb: increase number of registers saved in MacfbS
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 03/10] macfb: increase number of registers saved in MacfbState |
|
Date: |
Thu, 3 Mar 2022 15:25:30 +0000 |
On Thu, 3 Mar 2022 at 15:25, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> On Wed, 2 Mar 2022 at 21:31, Mark Cave-Ayland
> <mark.cave-ayland@ilande.co.uk> wrote:
> >
> > The MacOS toolbox ROM accesses a number of addresses between 0x0 and 0x200
> > during
> > initialisation and resolution changes. Whilst the function of many of these
> > registers is unknown, it is worth the minimal cost of saving these extra
> > values as
> > part of migration to help future-proof the migration stream for the q800
> > machine
> > as it starts to stabilise.
> >
> > Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> You should either bump the vmstate_macfb version numbers here,
> or at least note in the commit message that although it's a
> migration break we know nobody's migrating this device because
> of the bug we just fixed in the previous commit.
...where by "previous" I mean patch 1.
-- PMM