[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/10] macfb: set initial value of mode control registers
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v2 05/10] macfb: set initial value of mode control registers in macfb_common_realize() |
|
Date: |
Thu, 3 Mar 2022 15:28:26 +0000 |
On Wed, 2 Mar 2022 at 21:35, Mark Cave-Ayland
<mark.cave-ayland@ilande.co.uk> wrote:
>
> If booting Linux directly in the q800 machine using -kernel rather than using
> a
> MacOS toolbox ROM, the mode control registers are never initialised,
> causing macfb_mode_write() to fail to determine the current resolution after
> migration. Resolve this by always setting the initial values of the mode
> control
> registers based upon the initial macfb properties during realize.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
> hw/display/macfb.c | 8 ++++++++
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
[PATCH v2 04/10] macfb: add VMStateDescription fields for display type and VBL timer, Mark Cave-Ayland, 2022/03/02
[PATCH v2 05/10] macfb: set initial value of mode control registers in macfb_common_realize(), Mark Cave-Ayland, 2022/03/02
[PATCH v2 06/10] esp: introduce esp_set_pdma_cb() function, Mark Cave-Ayland, 2022/03/02
[PATCH v2 07/10] esp: introduce esp_pdma_cb() function, Mark Cave-Ayland, 2022/03/02
[PATCH v2 08/10] esp: convert ESPState pdma_cb from a function pointer to an integer, Mark Cave-Ayland, 2022/03/02
[PATCH v2 09/10] esp: include the current PDMA callback in the migration stream, Mark Cave-Ayland, 2022/03/02