[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 2/7] target/ppc: use ext32u and deposit in do_vx_vmulhw_i64
From: |
matheus . ferst |
Subject: |
[PATCH 2/7] target/ppc: use ext32u and deposit in do_vx_vmulhw_i64 |
Date: |
Fri, 4 Mar 2022 14:51:51 -0300 |
From: Matheus Ferst <matheus.ferst@eldorado.org.br>
Fixes: 29e9dfcf755e ("target/ppc: vmulh* instructions without helpers")
Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
---
target/ppc/translate/vmx-impl.c.inc | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/target/ppc/translate/vmx-impl.c.inc
b/target/ppc/translate/vmx-impl.c.inc
index c5d02d13fe..8ea1d2c96a 100644
--- a/target/ppc/translate/vmx-impl.c.inc
+++ b/target/ppc/translate/vmx-impl.c.inc
@@ -3162,19 +3162,16 @@ static void do_vx_vmulhw_i64(TCGv_i64 t, TCGv_i64 a,
TCGv_i64 b, bool sign)
{
TCGv_i64 hh, lh, temp;
- uint64_t c;
hh = tcg_temp_new_i64();
lh = tcg_temp_new_i64();
temp = tcg_temp_new_i64();
- c = 0xFFFFFFFF;
-
if (sign) {
tcg_gen_ext32s_i64(lh, a);
tcg_gen_ext32s_i64(temp, b);
} else {
- tcg_gen_andi_i64(lh, a, c);
- tcg_gen_andi_i64(temp, b, c);
+ tcg_gen_ext32u_i64(lh, a);
+ tcg_gen_ext32u_i64(temp, b);
}
tcg_gen_mul_i64(lh, lh, temp);
@@ -3188,8 +3185,7 @@ static void do_vx_vmulhw_i64(TCGv_i64 t, TCGv_i64 a,
TCGv_i64 b, bool sign)
tcg_gen_mul_i64(hh, hh, temp);
tcg_gen_shri_i64(lh, lh, 32);
- tcg_gen_andi_i64(hh, hh, c << 32);
- tcg_gen_or_i64(t, hh, lh);
+ tcg_gen_deposit_i64(t, hh, lh, 0, 32);
tcg_temp_free_i64(hh);
tcg_temp_free_i64(lh);
--
2.25.1
- [PATCH 0/7] target/ppc: Vector/VSX instruction batch fixes, matheus . ferst, 2022/03/04
- [PATCH 1/7] target/ppc: Fix vmul[eo]* instructions marked 2.07, matheus . ferst, 2022/03/04
- [PATCH 2/7] target/ppc: use ext32u and deposit in do_vx_vmulhw_i64,
matheus . ferst <=
- [PATCH 3/7] target/ppc: use extract/extract2 to create vrlqnm mask, matheus . ferst, 2022/03/04
- [PATCH 4/7] target/ppc: use andc in vrlqmi, matheus . ferst, 2022/03/04
- [PATCH 5/7] target/ppc: split XXGENPCV macros for readability, matheus . ferst, 2022/03/04
- [PATCH 6/7] target/ppc: Add missing helper_reset_fpstatus to VSX_MAX_MINC, matheus . ferst, 2022/03/04
- [PATCH 7/7] target/ppc: Add missing helper_reset_fpstatus to helper_XVCVSPBF16, matheus . ferst, 2022/03/04