Re: [PATCH V7 18/29] vfio-pci: refactor for cpr

[Steven Sistare]

On 3/3/2022 6:21 PM, Alex Williamson wrote:
> On Wed, 22 Dec 2021 11:05:23 -0800
> Steve Sistare <steven.sistare@oracle.com> wrote:
> 
>> +    if (vfio_notifier_init(vdev, &vdev->intx.unmask, "intx-unmask", 0)) {
> ...
>> +    vfio_notifier_cleanup(vdev, &vdev->intx.unmask, "intx-unmask", 0);
> ...
>> +    vfio_notifier_cleanup(vdev, &vdev->intx.unmask, "intx-unmask", 0);
> ...
>> +    ret = vfio_notifier_init(vdev, &vdev->intx.interrupt, "intx-interrupt", 
>> 0);
> ...
>> +        vfio_notifier_cleanup(vdev, &vdev->intx.interrupt, 
>> "intx-interrupt", 0);
> ...
>> +    vfio_notifier_cleanup(vdev, &vdev->intx.interrupt, "intx-interrupt", 0);
> ...
>> +    const char *name = "kvm_interrupt";
> ...
>> +    if (vfio_notifier_init(vdev, &vector->kvm_interrupt, name, nr)) {
> ...
>> +        vfio_notifier_cleanup(vdev, &vector->kvm_interrupt, name, nr);
> ...
>> +        vfio_notifier_cleanup(vdev, &vector->kvm_interrupt, name, nr);
> ...
>> +    vfio_notifier_cleanup(vdev, &vector->kvm_interrupt, "kvm_interrupt", 
>> nr);
> ...
>> +    if (vfio_notifier_init(vdev, &vector->interrupt, "interrupt", nr)) {
> ...
>> +        if (vfio_notifier_init(vdev, &vector->interrupt, "interrupt", i)) {
> ...
>> +            vfio_notifier_cleanup(vdev, &vector->interrupt, "interrupt", i);
> ...
>> +            vfio_notifier_cleanup(vdev, &vector->interrupt, "interrupt", i);
> ...
>> +    if (vfio_notifier_init(vdev, &vdev->err_notifier, "err", 0)) {
> ...
>> +        vfio_notifier_cleanup(vdev, &vdev->err_notifier, "err_notifier", 0);
> ...
>> +    vfio_notifier_cleanup(vdev, &vdev->err_notifier, "err_notifier", 0);
> ...
>> +    if (vfio_notifier_init(vdev, &vdev->req_notifier, "req", 0)) {
> ...
>> +        vfio_notifier_cleanup(vdev, &vdev->req_notifier, "req_notifier", 0);
> ...
>> +    vfio_notifier_cleanup(vdev, &vdev->req_notifier, "req_notifier", 0);
> 
> Something seems to have gone astray with "err" and "req" vs
> "err_notifier" and "req_notifier".  The pattern is broken.  Thanks,
> 
> Alex

Super catch, thanks.  Will fix:
  "err" -> "err_notifier"
  "req" -> "req_notifier"

- Steve