[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 13/18] tests/tcg: add vectorised sha512 versions
From: |
Alex Bennée |
Subject: |
Re: [PULL 13/18] tests/tcg: add vectorised sha512 versions |
Date: |
Wed, 09 Mar 2022 11:18:02 +0000 |
User-agent: |
mu4e 1.7.9; emacs 28.0.91 |
Thomas Huth <thuth@redhat.com> writes:
> On 01/03/2022 10.47, Alex Bennée wrote:
>> This builds vectorised versions of sha512 to exercise the vector code:
>> - aarch64 (AdvSimd)
>> - i386 (SSE)
>> - s390x (MVX)
>> - ppc64/ppc64le (power10 vectors)
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>> Message-Id: <20220225172021.3493923-14-alex.bennee@linaro.org>
> [...]
>> diff --git a/tests/tcg/s390x/Makefile.target
>> b/tests/tcg/s390x/Makefile.target
>> index 1a7238b4eb..e53b599b22 100644
>> --- a/tests/tcg/s390x/Makefile.target
>> +++ b/tests/tcg/s390x/Makefile.target
>> @@ -25,3 +25,12 @@ run-gdbstub-signals-s390x: signals-s390x
>> EXTRA_RUNS += run-gdbstub-signals-s390x
>> endif
>> +
>> +# MVX versions of sha512
>> +sha512-mvx: CFLAGS=-march=z13 -mvx -O3
>> +sha512-mvx: sha512.c
>> + $(CC) $(CFLAGS) $(EXTRA_CFLAGS) $< -o $@ $(LDFLAGS)
>> +
>> +run-sha512-mvx: QEMU_OPTS+=-cpu max
>> +
>> +TESTS+=sha512-mvx
>
> When running "make check-tcg" on my s390x host, I'm now getting this error:
>
> TEST sha512-mvx on s390x
> qemu-s390x: warning: 'msa5-base' requires 'kimd-sha-512'.
> qemu-s390x: warning: 'msa5-base' requires 'klmd-sha-512'.
> make[2]: *** [../Makefile.target:156: run-sha512-mvx] Error 10
Hmm I see the warning but it doesn't fail for me. Dropping -cpu max
makes the working go away. I thought we needed it to ensure the CPU
model had s390x's vector instructions enabled.
> Any ideas how to fix this?
>
> Thomas
--
Alex Bennée
- [PULL 08/18] scripts/ci: allow for a secondary runner, (continued)
- [PULL 08/18] scripts/ci: allow for a secondary runner, Alex Bennée, 2022/03/01
- [PULL 06/18] tests/docker: introduce debian-riscv64-test-cross, Alex Bennée, 2022/03/01
- [PULL 10/18] tests/tcg/ppc64: clean-up handling of byte-reverse, Alex Bennée, 2022/03/01
- [PULL 12/18] tests/tcg: add sha512 test, Alex Bennée, 2022/03/01
- [PULL 14/18] travis.yml: Update the s390x jobs to Ubuntu Focal, Alex Bennée, 2022/03/01
- [PULL 09/18] gitlab: add a new aarch32 custom runner definition, Alex Bennée, 2022/03/01
- [PULL 15/18] gitlab: upgrade the job definition for s390x to 20.04, Alex Bennée, 2022/03/01
- [PULL 16/18] tests/tcg: completely disable threadcount for sh4, Alex Bennée, 2022/03/01
- [PULL 13/18] tests/tcg: add vectorised sha512 versions, Alex Bennée, 2022/03/01
- [PULL 07/18] scripts/ci: add build env rules for aarch32 on aarch64, Alex Bennée, 2022/03/01
- [PULL 17/18] semihosting/arm-compat: replace heuristic for softmmu SYS_HEAPINFO, Alex Bennée, 2022/03/01
- [PULL 18/18] tests/tcg: port SYS_HEAPINFO to a system test, Alex Bennée, 2022/03/01
- [PULL 11/18] tests/tcg: build sha1-vector with O3 and compare, Alex Bennée, 2022/03/01
- Re: [PULL 00/18] testing and semihosting updates, Peter Maydell, 2022/03/02