[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 06/18 for-7.0] migration: fix use of TLS PSK credentials with
From: |
Daniel P . Berrangé |
Subject: |
[PATCH v2 06/18 for-7.0] migration: fix use of TLS PSK credentials with a UNIX socket |
Date: |
Thu, 10 Mar 2022 17:18:09 +0000 |
The migration TLS code has a check mandating that a hostname be
available when starting a TLS session. This is expected when using
x509 credentials, but is bogus for PSK and anonymous credentials
as neither involve hostname validation.
The TLS crdentials object gained suitable error reporting in the
case of TLS with x509 credentials, so there is no longer any need
for the migration code to do its own (incorrect) validation.
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
migration/tls.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/migration/tls.c b/migration/tls.c
index ca1ea3bbdd..32c384a8b6 100644
--- a/migration/tls.c
+++ b/migration/tls.c
@@ -137,10 +137,6 @@ QIOChannelTLS *migration_tls_client_create(MigrationState
*s,
if (s->parameters.tls_hostname && *s->parameters.tls_hostname) {
hostname = s->parameters.tls_hostname;
}
- if (!hostname) {
- error_setg(errp, "No hostname available for TLS");
- return NULL;
- }
tioc = qio_channel_tls_new_client(
ioc, creds, hostname, errp);
--
2.34.1
- [PATCH v2 11/18] tests: expand the migration precopy helper to support failures, (continued)
- [PATCH v2 11/18] tests: expand the migration precopy helper to support failures, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 08/18] tests: merge code for UNIX and TCP migration pre-copy tests, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 07/18] tests: switch MigrateStart struct to be stack allocated, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 14/18] tests: convert XBZRLE migration test to use common helper, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 16/18] tests: add multifd migration tests of TLS with PSK credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 12/18] tests: add migration tests of TLS with PSK credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 06/18 for-7.0] migration: fix use of TLS PSK credentials with a UNIX socket,
Daniel P . Berrangé <=
- [PATCH v2 15/18] tests: convert multifd migration tests to use common helper, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 18/18] tests: ensure migration status isn't reported as failed, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 17/18] tests: add multifd migration tests of TLS with x509 credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 13/18] tests: add migration tests of TLS with x509 credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 04/18] tests: print newline after QMP response in qtest logs, Daniel P . Berrangé, 2022/03/10
- Re: [PATCH v2 00/18] tests: introduce testing coverage for TLS with migration, Peter Xu, 2022/03/10