[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 04/18] tests: print newline after QMP response in qtest logs
From: |
Daniel P . Berrangé |
Subject: |
[PATCH v2 04/18] tests: print newline after QMP response in qtest logs |
Date: |
Thu, 10 Mar 2022 17:18:07 +0000 |
The QMP commands have a trailing newline, but the response does not.
This makes the qtest logs hard to follow as the next QMP command
appears in the same line as the previous QMP response.
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
tests/qtest/libqtest.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index a85f8a6d05..d5b6558876 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -625,10 +625,13 @@ QDict *qmp_fd_receive(int fd)
}
if (log) {
- len = write(2, &c, 1);
+ g_assert(write(2, &c, 1) == 1);
}
json_message_parser_feed(&qmp.parser, &c, 1);
}
+ if (log) {
+ g_assert(write(2, "\n", 1) == 1);
+ }
json_message_parser_destroy(&qmp.parser);
return qmp.response;
--
2.34.1
- Re: [PATCH v2 14/18] tests: convert XBZRLE migration test to use common helper, (continued)
- [PATCH v2 16/18] tests: add multifd migration tests of TLS with PSK credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 12/18] tests: add migration tests of TLS with PSK credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 06/18 for-7.0] migration: fix use of TLS PSK credentials with a UNIX socket, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 15/18] tests: convert multifd migration tests to use common helper, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 18/18] tests: ensure migration status isn't reported as failed, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 17/18] tests: add multifd migration tests of TLS with x509 credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 13/18] tests: add migration tests of TLS with x509 credentials, Daniel P . Berrangé, 2022/03/10
- [PATCH v2 04/18] tests: print newline after QMP response in qtest logs,
Daniel P . Berrangé <=
- Re: [PATCH v2 00/18] tests: introduce testing coverage for TLS with migration, Peter Xu, 2022/03/10