Re: [PULL for-7.1 03/36] util/log: Pass Error pointer to qemu_set_log

[Philippe Mathieu-Daudé]

On 20/3/22 18:11, Richard Henderson wrote:
> Do not force exit within qemu_set_log.  Pass an Error
> value back up the stack as per usual.

"Pass an Error value back up the stack [and return a boolean
value] as per usual.", see:

87bky6ugmx.fsf@pond.sub.org/">https://lore.kernel.org/qemu-devel/87bky6ugmx.fsf@pond.sub.org/

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/qemu/log.h                   |  2 +-
>   bsd-user/main.c                      |  2 +-
>   linux-user/main.c                    |  2 +-
>   monitor/misc.c                       |  7 ++++++-
>   qemu-img.c                           |  2 +-
>   qemu-io.c                            |  2 +-
>   qemu-nbd.c                           |  2 +-
>   scsi/qemu-pr-helper.c                |  2 +-
>   softmmu/vl.c                         |  4 ++--
>   storage-daemon/qemu-storage-daemon.c |  2 +-
>   tests/unit/test-logging.c            |  2 +-
>   util/log.c                           | 10 +++++-----
>   12 files changed, 22 insertions(+), 17 deletions(-)
>
> diff --git a/include/qemu/log.h b/include/qemu/log.h
> index 08b0cd0bb3..64f28785ae 100644
> --- a/include/qemu/log.h
> +++ b/include/qemu/log.h
> @@ -147,7 +147,7 @@ typedef struct QEMULogItem {
>   
>   extern const QEMULogItem qemu_log_items[];
>   
> -void qemu_set_log(int log_flags);
> +void qemu_set_log(int log_flags, Error **errp);