Re: [PATCH v3 3/5] softmmu/cpus: Free cpu->halt_cond in generic_destroy_vcpu_thread()

[Philippe Mathieu-Daudé]

On 22/3/22 13:52, Mark Kanda wrote:
> Thanks Philippe,
>
> On 3/21/2022 5:12 PM, Philippe Mathieu-Daudé wrote:
> > On 21/3/22 15:14, Mark Kanda wrote:
> > > vCPU hotunplug related leak reported by Valgrind:
> > >
> > > ==102631== 56 bytes in 1 blocks are definitely lost in loss record 
> > > 5,089 of 8,555
> > > ==102631==    at 0x4C3ADBB: calloc (vg_replace_malloc.c:1117)
> > > ==102631==    by 0x69EE4CD: g_malloc0 (in 
> > > /usr/lib64/libglib-2.0.so.0.5600.4)
> > > ==102631==    by 0x924452: kvm_start_vcpu_thread (kvm-accel-ops.c:69)
> >
> > Here we want to extract a common generic_init_vcpu_thread().
>
> How about I add extracting 'generic_init_vcpu_thread()' as a separate 
> cleanup patch at the end? I'll also drop my xsave_buf patch due to your 
> followup.

I plan to queue patch #4 for v7.0, but I'd rather have the first ones
reworked by extracting the common vcpu_thread_create() code (which
only differs in TCG/RR). I'll give it a try and send a respin later
today.