|
From: | Alex Bennée |
Subject: | Re: [PULL for-7.1 08/36] *: Use fprintf between qemu_log_lock/unlock |
Date: | Wed, 23 Mar 2022 17:22:41 +0000 |
User-agent: | mu4e 1.7.10; emacs 28.0.92 |
Richard Henderson <richard.henderson@linaro.org> writes: > Inside qemu_log, we perform qemu_log_lock/unlock, which need > not be done if we have already performed the lock beforehand. > > Always check the result of qemu_log_lock -- only checking > qemu_loglevel_mask races with the acquisition of the lock > on the logfile. I'm not sure I like introducing all these raw fprintfs over introducing a function like qemu_log__locked(). -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |