|
From: | Alex Bennée |
Subject: | Re: [PULL for-7.1 07/36] hw/xen: Split out xen_pv_output_msg |
Date: | Wed, 23 Mar 2022 17:19:46 +0000 |
User-agent: | mu4e 1.7.10; emacs 28.0.92 |
Richard Henderson <richard.henderson@linaro.org> writes: > Do not replicate the individual logging statements. > Use qemu_log_lock/unlock instead of qemu_log directly. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> I don't know why Xen wants to have it's own special handling for errors. It seems a lot of the xen_pv_printf's of level 0 should probably be using qemu's report_err infrastructure. But this change itself seems sane: Reviewed-by: Alex Bennée <alex.bennee@linaro.org> -- Alex Bennée
[Prev in Thread] | Current Thread | [Next in Thread] |