qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] coreaudio: Notify error in coreaudio_init_out


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2] coreaudio: Notify error in coreaudio_init_out
Date: Mon, 28 Mar 2022 20:50:15 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 26/2/22 12:59, Akihiko Odaki wrote:
Otherwise, the audio subsystem tries to use the voice and
eventually aborts due to the maximum number of samples in the
buffer is not set.

Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
---
  audio/coreaudio.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/audio/coreaudio.c b/audio/coreaudio.c
index d8a21d3e507..d7cfdcc4fc4 100644
--- a/audio/coreaudio.c
+++ b/audio/coreaudio.c
@@ -604,6 +604,8 @@ static int coreaudio_init_out(HWVoiceOut *hw, struct 
audsettings *as,
              coreaudio_playback_logerr(status,
                                        "Could not remove voice property change 
listener\n");
          }
+
+        return -1;
      }
return 0;

Merged as commit bd7819de22.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]