Re: [RFC PATCH v7 09/29] target/loongarch: Add TLB instruction support

[Richard Henderson]

On 3/28/22 06:57, Xiaojuan Yang wrote:
> +static void output_empty(DisasContext *ctx, arg_empty *a,
> +                         const char *mnemonic)
> +{
> +}

No, you must still do

    output(ctx, mnemonic, "");

> +static bool trans_tlbwr(DisasContext *ctx, arg_tlbwr *a)
> +{
> +    if (check_plv(ctx)) {
> +        return false;
> +    }
> +    gen_helper_tlbwr(cpu_env);
> +
> +    if (ctx->mem_idx != MMU_DA_IDX) {
> +        tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next + 4);
> +        ctx->base.is_jmp = DISAS_EXIT;
> +    }

You may want to create a helper function for this condition.

> +static bool trans_tlbclr(DisasContext *ctx, arg_tlbclr *a)
> +{
> +    if (check_plv(ctx)) {
> +        return false;
> +    }
> +    gen_helper_tlbclr(cpu_env);
> +    tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next + 4);
> +    ctx->base.is_jmp = DISAS_EXIT;

Missing it here...

> +static bool trans_tlbflush(DisasContext *ctx, arg_tlbflush *a)
> +{
> +    if (check_plv(ctx)) {
> +        return false;
> +    }
> +    gen_helper_tlbflush(cpu_env);
> +    tcg_gen_movi_tl(cpu_pc, ctx->base.pc_next + 4);
> +    ctx->base.is_jmp = DISAS_EXIT;
> +    return true;
> +}

... and here.


r~