qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] github: fix config mistake preventing repo lockdown commenti


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH] github: fix config mistake preventing repo lockdown commenting
Date: Tue, 29 Mar 2022 00:05:06 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 23/3/22 12:45, Daniel P. Berrangé wrote:
The config key names were all wrong,

Since commit 2b678923bb@repo-lockdown (22 Aug 2020, 2 years ago...):

  feat: move to GitHub Actions

  BREAKING CHANGE: The deployment method and configuration
  options have changed.

https://github.com/dessant/repo-lockdown/commit/2b678923bbf2df051

resulting in the repo lockdown
throwing warnings:

   Unexpected input(s) 'pull-comment', 'lock-pull', 'close-pull',
   valid inputs are ['github-token', 'exclude-issue-created-before',
   'exclude-issue-labels', 'issue-labels', 'issue-comment',
   'skip-closed-issue-comment', 'close-issue', 'lock-issue',
   'issue-lock-reason', 'exclude-pr-created-before', 'exclude-pr-labels',
   'pr-labels', 'pr-comment', 'skip-closed-pr-comment', 'close-pr',
   'lock-pr', 'pr-lock-reason', 'process-only', 'log-output']

It still locked down the pull requests, due to its default config,
but didn't leave the friendly message explaining why.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
  .github/workflows/lockdown.yml | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Preferably with description tweaked:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]