[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp |
Date: |
Tue, 29 Mar 2022 17:46:13 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> The changed examples were lacking mandatory member @timestamp.
> Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/run-state.json | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index 1b9f64c9cd..7f1c788c4e 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -426,7 +426,8 @@
> # Example:
> #
> # <- { "event": "GUEST_PANICKED",
> -# "data": { "action": "pause" } }
> +# "data": { "action": "pause" },
> +# "timestamp": { "seconds": 1648245231, "microseconds": 900001 } }
> #
> ##
> { 'event': 'GUEST_PANICKED',
> @@ -446,7 +447,8 @@
> # Example:
> #
> # <- { "event": "GUEST_CRASHLOADED",
> -# "data": { "action": "run" } }
> +# "data": { "action": "run" },
> +# "timestamp": { "seconds": 1648245259, "microseconds": 893771 } }
> #
> ##
> { 'event': 'GUEST_CRASHLOADED',
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event, (continued)
- [PATCH v3 04/14] qapi: fix example of BLOCK_JOB_PENDING event, Victor Toso, 2022/03/28
- [PATCH v3 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, Victor Toso, 2022/03/28
- [PATCH v3 07/14] qapi: fix example of UNPLUG_PRIMARY event, Victor Toso, 2022/03/28
- [PATCH v3 05/14] qapi: fix example of DUMP_COMPLETED event, Victor Toso, 2022/03/28
- [PATCH v3 08/14] qapi: fix example of FAILOVER_NEGOTIATED event, Victor Toso, 2022/03/28
- [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events, Victor Toso, 2022/03/28
- [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp, Victor Toso, 2022/03/28
- Re: [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp,
Markus Armbruster <=
- [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/28
- [PATCH v3 12/14] qapi: ui examples: add missing @websocket member, Victor Toso, 2022/03/28
- [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event, Victor Toso, 2022/03/28
- [PATCH v3 14/14] qapi: fix example of dump-guest-memory, Victor Toso, 2022/03/28
- Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section, Markus Armbruster, 2022/03/29