[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event |
Date: |
Tue, 29 Mar 2022 17:55:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output lacks mandatory member @timestamp. Provide it.
>
> Event's @data member is missing @info object. Provide it.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> Reviewed-by: John Snow <jsnow@redhat.com>
> ---
> qapi/acpi.json | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/qapi/acpi.json b/qapi/acpi.json
> index 51f0d55db7..d148f6db9f 100644
> --- a/qapi/acpi.json
> +++ b/qapi/acpi.json
> @@ -133,8 +133,9 @@
> # Example:
> #
> # <- { "event": "ACPI_DEVICE_OST",
> -# "data": { "device": "d1", "slot": "0",
> -# "slot-type": "DIMM", "source": 1, "status": 0 } }
> +# "data": { "info": { "device": "d1", "slot": "0",
> +# "slot-type": "DIMM", "source": 1, "status": 0 } },
> +# "timestamp": { "seconds": 1265044230, "microseconds": 450486 } }
> #
> ##
> { 'event': 'ACPI_DEVICE_OST',
Reviewed-by: Markus Armbruster <armbru@redhat.com>
- [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events, (continued)
- [PATCH v3 09/14] qapi: fix examples: SHUTDOWN and RESET events, Victor Toso, 2022/03/28
- [PATCH v3 10/14] qapi: run-state examples: add missing @timestamp, Victor Toso, 2022/03/28
- [PATCH v3 11/14] qapi: fix example of MEMORY_FAILURE, Victor Toso, 2022/03/28
- [PATCH v3 12/14] qapi: ui examples: add missing @websocket member, Victor Toso, 2022/03/28
- [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event, Victor Toso, 2022/03/28
- Re: [PATCH v3 13/14] qapi: fix example of ACPI_DEVICE_OST event,
Markus Armbruster <=
- [PATCH v3 14/14] qapi: fix example of dump-guest-memory, Victor Toso, 2022/03/28
- Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section, Markus Armbruster, 2022/03/29
- Re: [PATCH v3 00/14] Fix some qapi examples and a TODO section, Markus Armbruster, 2022/03/31