qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v21 8/9] migration-test: Export migration-test util funtions


From: Hyman
Subject: Re: [PATCH v21 8/9] migration-test: Export migration-test util funtions
Date: Thu, 31 Mar 2022 23:35:04 +0800
User-agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0



在 2022/3/30 2:54, Peter Xu 写道:
On Wed, Mar 16, 2022 at 09:07:20PM +0800, huangy81@chinatelecom.cn wrote:
+void wait_for_serial(const char *tmpfs, const char *side)

Passing over tmpfs over and over (even if it's mostly a constant) doesn't
sound appealing to me..

I hope there's still a way that we could avoid doing that when spliting the
file.  Or, how about you just add a new test into migration-test?  After
all all migration tests (including auto-converge) is there, and I don't
strongly feel that we need a separate file urgently.
Ok, i separated file just for code readability. I'm not very insistent to do this if we think it's ok to add dirtylimit test to migration test. Thanks for the comment. :)

Yong
 > Thanks,




reply via email to

[Prev in Thread] Current Thread [Next in Thread]