qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 08/15] disas: use result of ->read_memory_func


From: Richard Henderson
Subject: Re: [PATCH v1 08/15] disas: use result of ->read_memory_func
Date: Sat, 9 Apr 2022 09:07:14 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0

On 4/8/22 09:47, Alex Bennée wrote:
This gets especially confusing if you start plugging in host addresses
from a trace and you wonder why the output keeps changing. Report when
read_memory_func fails instead of blindly disassembling the buffer
contents.

Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
---
  disas.c          | 20 ++++++-------
  disas/capstone.c | 73 ++++++++++++++++++++++++++++--------------------
  2 files changed, 53 insertions(+), 40 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]