[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 06/15] monitor: expose monitor_puts to rest of code
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v1 06/15] monitor: expose monitor_puts to rest of code |
Date: |
Thu, 21 Apr 2022 16:45:46 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Alex Bennée <alex.bennee@linaro.org> writes:
> This helps us construct strings elsewhere before echoing to the
> monitor. It avoids having to jump through hoops like:
>
> monitor_printf(mon, "%s", s->str);
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
There's just one caller other than monitor_vprintf(). Even if you add a
few more, I'm not sure keeping it in the interface is worthwhile.
If we conclude it is, then this patch should come with a conversion of
existing uses of monitor_printf(MON, "%s", STR) to monitor_puts(MON,
STR).
If we conclude it isn't, switch the lone caller to monitor_printf() and
make monitor_puts() static in monitor.c.
- [PATCH v1 04/15] accel/tcg: move trace events to correct location, (continued)
- [PATCH v1 04/15] accel/tcg: move trace events to correct location, Alex Bennée, 2022/04/08
- [PATCH v1 09/15] cputlb: add tracepoints for the protect/unprotect helpers, Alex Bennée, 2022/04/08
- [PATCH v1 07/15] disas: generalise plugin_printf and use for monitor_disas, Alex Bennée, 2022/04/08
- [PATCH v1 01/15] tests/avocado: update aarch64_virt test to exercise -cpu max, Alex Bennée, 2022/04/08
- [PATCH v1 03/15] docs/devel: drop :hidden: and :includehidden: tags, Alex Bennée, 2022/04/08
- [PATCH v1 06/15] monitor: expose monitor_puts to rest of code, Alex Bennée, 2022/04/08
- [PATCH v1 05/15] accel/tcg: add tb_invalidate_phy_pages_fast tracepoint, Alex Bennée, 2022/04/08
- [PATCH v1 12/15] tests/tcg: add memory-sve test for aarch64, Alex Bennée, 2022/04/08
- [PATCH v1 08/15] disas: use result of ->read_memory_func, Alex Bennée, 2022/04/08
- [PATCH v1 10/15] cputlb: add tracepoints for TB invalidation, Alex Bennée, 2022/04/08
- [PATCH v1 13/15] plugins: extend execlog to filter matches, Alex Bennée, 2022/04/08
- [PATCH v1 11/15] accel/tcg: add tb_invalidate_phys_page_range tracepoint, Alex Bennée, 2022/04/08