Re: [PATCH 06/34] configure: move --enable/--disable-debug-info to second option parsing pass

[Thomas Huth]

On 20/04/2022 17.33, Paolo Bonzini wrote:
> $debug_info is not needed anywhere except in the final meson invocation,
> no need to special case it.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>   configure | 14 +++++---------
>   1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/configure b/configure
> index 48ae18f47f..07053e7b27 100755
> --- a/configure
> +++ b/configure
> @@ -244,7 +244,6 @@ audio_drv_list="default"
>   block_drv_rw_whitelist=""
>   block_drv_ro_whitelist=""
>   host_cc="cc"
> -debug_info="yes"
>   lto="false"
>   stack_protector=""
>   safe_stack=""
> @@ -304,6 +303,7 @@ vhost_user_fs="$default_feature"
>   vhost_vdpa="$default_feature"
>   rdma="$default_feature"
>   pvrdma="$default_feature"
> +debug_info="yes"
>   debug_tcg="no"
>   debug="no"
>   sanitizers="no"
> @@ -379,10 +379,6 @@ for opt do
>     ;;
>     --extra-ldflags=*) EXTRA_LDFLAGS="$EXTRA_LDFLAGS $optarg"
>     ;;
> -  --enable-debug-info) debug_info="yes"
> -  ;;
> -  --disable-debug-info) debug_info="no"
> -  ;;
>     --cross-cc-*[!a-zA-Z0-9_-]*=*) error_exit "Passed bad --cross-cc-FOO option"
>     ;;
>     --cross-cc-cflags-*) cc_arch=${opt#--cross-cc-cflags-}; 
> cc_arch=${cc_arch%%=*}
> @@ -759,12 +755,12 @@ for opt do
>     ;;
>     --extra-ldflags=*)
>     ;;
> -  --enable-debug-info)
> -  ;;
> -  --disable-debug-info)
> -  ;;
>     --cross-cc-*)
>     ;;
> +  --enable-debug-info) debug_info="yes"
> +  ;;
> +  --disable-debug-info) debug_info="no"
> +  ;;
>     --enable-modules)
>         modules="yes"
>     ;;

Reviewed-by: Thomas Huth <thuth@redhat.com>