[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 30/41] Move error_printf_unless_qmp() with monitor unit
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 30/41] Move error_printf_unless_qmp() with monitor unit |
Date: |
Wed, 20 Apr 2022 16:42:42 +0100 |
User-agent: |
Mutt/2.1.5 (2021-12-30) |
On Wed, Apr 20, 2022 at 05:26:13PM +0400, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Since it depends on monitor code, and error_vprintf_unless_qmp() is
> already there.
>
> This will help to move error-report in a common subproject.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> include/monitor/monitor.h | 3 +++
> include/qemu/error-report.h | 2 --
> monitor/monitor.c | 10 ++++++++++
> stubs/error-printf.c | 1 +
> ui/vnc.c | 1 +
> util/error-report.c | 11 -----------
> 6 files changed, 15 insertions(+), 13 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 24/41] include: move qdict_{crumple,flatten} declarations, (continued)
- [PATCH 26/41] compiler.h: add QEMU_SANITIZE_{ADDRESS,THREAD}, marcandre . lureau, 2022/04/20
- [PATCH 27/41] Use QEMU_SANITIZE_THREAD, marcandre . lureau, 2022/04/20
- [PATCH 28/41] Use QEMU_SANITIZE_ADDRESS, marcandre . lureau, 2022/04/20
- [PATCH 29/41] tests: run-time skip test-qga if TSAN is enabled, marcandre . lureau, 2022/04/20
- [PATCH 30/41] Move error_printf_unless_qmp() with monitor unit, marcandre . lureau, 2022/04/20
- Re: [PATCH 30/41] Move error_printf_unless_qmp() with monitor unit,
Daniel P . Berrangé <=
- [PATCH 31/41] qga: move qga_get_host_name(), marcandre . lureau, 2022/04/20
- [PATCH 32/41] qtest: simplify socket_send(), marcandre . lureau, 2022/04/20
- [PATCH 35/41] util: simplify write in signal handler, marcandre . lureau, 2022/04/20
- [PATCH 34/41] libqtest: split QMP part in libqmp, marcandre . lureau, 2022/04/20