qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu.qmp PATCH 04/12] update project URLs


From: John Snow
Subject: Re: [qemu.qmp PATCH 04/12] update project URLs
Date: Mon, 25 Apr 2022 14:19:27 -0400



On Mon, Apr 25, 2022, 6:56 AM Daniel P. Berrangé <berrange@redhat.com> wrote:
On Fri, Apr 22, 2022 at 02:49:32PM -0400, John Snow wrote:
> Point to this library's URLs instead of the entire project's.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  setup.cfg | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/setup.cfg b/setup.cfg
> index c21f2ce..0a1c215 100644
> --- a/setup.cfg
> +++ b/setup.cfg
> @@ -5,8 +5,8 @@ author = QEMU Project
>  author_email = qemu-devel@nongnu.org
>  maintainer = John Snow
>  maintainer_email = jsnow@redhat.com
> -url = "" href="https://www.qemu.org/" rel="noreferrer noreferrer" target="_blank">https://www.qemu.org/
> -download_url = https://www.qemu.org/download/
> +url = "" href="https://gitlab.com/qemu-project/python-qemu-qmp" rel="noreferrer noreferrer" target="_blank">https://gitlab.com/qemu-project/python-qemu-qmp
> +download_url = https://gitlab.com/qemu-project/python-qemu-qmp/-/packages

Auto-generated tarballs are not guaranteed to have fixed content forever
so I tend to avoid pointing to those. Assuming you're intending to upload
to pypi, I'd link to that instead as the "official" tarball source.

This metadata will also be used for PyPI, so that seemed cyclic.

I linked it to the gitlab package repository, where I *intend* to push built wheels (and dev interstitial builds) but maybe that's too "inside baseball" for a pypi link.

Seems weird for a Pypi package to point to itself on pypi, but maybe that's correct?



>  description = QEMU Monitor Protocol library
>  long_description = file:PACKAGE.rst
>  long_description_content_type = text/x-rst


With regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


reply via email to

[Prev in Thread] Current Thread [Next in Thread]