Re: [qemu.qmp PATCH 04/12] update project URLs

[John Snow]

On Fri, Apr 29, 2022 at 10:06 AM Beraldo Leal <bleal@redhat.com> wrote:
>
> On Fri, Apr 22, 2022 at 02:49:32PM -0400, John Snow wrote:
> > Point to this library's URLs instead of the entire project's.
> >
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >  setup.cfg | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/setup.cfg b/setup.cfg
> > index c21f2ce..0a1c215 100644
> > --- a/setup.cfg
> > +++ b/setup.cfg
> > @@ -5,8 +5,8 @@ author = QEMU Project
> >  author_email = qemu-devel@nongnu.org
> >  maintainer = John Snow
> >  maintainer_email = jsnow@redhat.com
> > -url = https://www.qemu.org/
> > -download_url = https://www.qemu.org/download/
> > +url = https://gitlab.com/qemu-project/python-qemu-qmp
> > +download_url = https://gitlab.com/qemu-project/python-qemu-qmp/-/packages
>
> Afaik (and I might be wrong), it seems that download_url is not
> recommended nowadays. External downloads got removed due to some abuse
> and problems.
>
> I remember reading about some changes in the distribution of Python
> packages in PyPi where, by default, PyPi will not parse and expose
> "download_url" for newly registered packages anymore. From PEP438:
>
> "Many package uploaders are not aware that specifying the “homepage” or
> “download-url” in their package metadata will needlessly slow down the
> installation process for all users."
>
> Please take this comment with a grain of salt, I'm not 100% sure about
> this and I might be missing something.
>

Neat. Good reference on PEP438. It was superseded:
https://peps.python.org/pep-0470/ ... but I am under the impression
that pip does not have this behavior anymore. Maybe I'm wrong? I
wasn't writing Python in 2014.

Though, I didn't realize that this field was *ever* used for external
download links by package managers. Fun. I'll have to do some reading,
but maybe I'll just remove the field for now, thanks for bringing this
to my attention.

--js