[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/68] linux-user/nios2: Adjust error return
From: |
Richard Henderson |
Subject: |
[PULL 04/68] linux-user/nios2: Adjust error return |
Date: |
Tue, 26 Apr 2022 11:18:03 -0700 |
Follow the kernel assembly, which considers all negative
return values to be errors.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220421151735.31996-5-richard.henderson@linaro.org>
---
linux-user/nios2/cpu_loop.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/linux-user/nios2/cpu_loop.c b/linux-user/nios2/cpu_loop.c
index 91737c568f..63afba5862 100644
--- a/linux-user/nios2/cpu_loop.c
+++ b/linux-user/nios2/cpu_loop.c
@@ -55,9 +55,14 @@ void cpu_loop(CPUNios2State *env)
env->regs[7], env->regs[8], env->regs[9],
0, 0);
+ /*
+ * See the code after translate_rc_and_ret: all negative
+ * values are errors (aided by userspace restricted to 2G),
+ * errno is returned positive in r2, and error indication
+ * is a boolean in r7.
+ */
env->regs[2] = abs(ret);
- /* Return value is 0..4096 */
- env->regs[7] = ret > 0xfffff000u;
+ env->regs[7] = ret < 0;
break;
case 1:
--
2.34.1
- [PULL 00/68] nios2 patch queue, Richard Henderson, 2022/04/26
- [PULL 01/68] linux-user/nios2: Hoist pc advance to the top of EXCP_TRAP, Richard Henderson, 2022/04/26
- [PULL 05/68] linux-user/nios2: Handle special qemu syscall return values, Richard Henderson, 2022/04/26
- [PULL 16/68] target/nios2: Split PC out of env->regs[], Richard Henderson, 2022/04/26
- [PULL 07/68] linux-user/nios2: Use QEMU_ESIGRETURN from do_rt_sigreturn, Richard Henderson, 2022/04/26
- [PULL 12/68] linux-user/nios2: Use force_sig_fault for EXCP_DEBUG, Richard Henderson, 2022/04/26
- [PULL 26/68] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields, Richard Henderson, 2022/04/26
- [PULL 22/68] target/nios2: Split control registers away from general registers, Richard Henderson, 2022/04/26
- [PULL 04/68] linux-user/nios2: Adjust error return,
Richard Henderson <=
- [PULL 08/68] tests/tcg/nios2: Re-enable linux-user tests, Richard Henderson, 2022/04/26
- [PULL 11/68] target/nios2: Build helper.c for system only, Richard Henderson, 2022/04/26
- [PULL 17/68] target/nios2: Split out helper for eret instruction, Richard Henderson, 2022/04/26
- [PULL 03/68] linux-user/nios2: Drop syscall 0 "workaround", Richard Henderson, 2022/04/26
- [PULL 02/68] linux-user/nios2: Fix clone child return, Richard Henderson, 2022/04/26
- [PULL 06/68] linux-user/nios2: Remove do_sigreturn, Richard Henderson, 2022/04/26
- [PULL 10/68] target/nios2: Remove nios2_cpu_record_sigsegv, Richard Henderson, 2022/04/26
- [PULL 13/68] target/nios2: Check supervisor on eret, Richard Henderson, 2022/04/26
- [PULL 14/68] target/nios2: Stop generating code if gen_check_supervisor fails, Richard Henderson, 2022/04/26
- [PULL 18/68] target/nios2: Fix BRET instruction, Richard Henderson, 2022/04/26