[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 56/60] target/arm: Enable FEAT_CSV2_2 for -cpu max
From: |
Richard Henderson |
Subject: |
Re: [PATCH v3 56/60] target/arm: Enable FEAT_CSV2_2 for -cpu max |
Date: |
Fri, 29 Apr 2022 11:06:23 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 4/29/22 02:52, Damien Hedde wrote:
The following checks are missing:
+ for HFG[W/R]TR_EL2.SCXTNUM_EL0/1
We do not yet support FEAT_FGT.
+ HCR_EL2.<NV2,NV1,NV> when accessing SCXTNUM_EL1, but maybe these are always
guaranteed to fail because we don't support the features ?
+ HCR_EL2.NV when accessing SCXTNUM_EL2
We do not yet support FEAT_NV or FEAT_NV2.
+ if (arm_is_el2_enabled(env) && !(hcr & HCR_ENSCXT)) {
This case is also present when accessing SCXTNUM_EL0 from el1 (but without "(hcr &
(HCR_TGE | HCR_E2H)) != (HCR_TGE | HCR_E2H)" precondition)
Quite right. Will fix.
r~
- [PATCH v3 49/60] target/arm: Add minimal RAS registers, (continued)
- [PATCH v3 49/60] target/arm: Add minimal RAS registers, Richard Henderson, 2022/04/17
- [PATCH v3 48/60] target/arm: Add isar_feature_{aa64,any}_ras, Richard Henderson, 2022/04/17
- [PATCH v3 50/60] target/arm: Enable SCR and HCR bits for RAS, Richard Henderson, 2022/04/17
- [PATCH v3 52/60] target/arm: Implement ESB instruction, Richard Henderson, 2022/04/17
- [PATCH v3 53/60] target/arm: Enable FEAT_RAS for -cpu max, Richard Henderson, 2022/04/17
- [PATCH v3 51/60] target/arm: Implement virtual SError exceptions, Richard Henderson, 2022/04/17
- [PATCH v3 54/60] target/arm: Enable FEAT_IESB for -cpu max, Richard Henderson, 2022/04/17
- [PATCH v3 56/60] target/arm: Enable FEAT_CSV2_2 for -cpu max, Richard Henderson, 2022/04/17
- [PATCH v3 57/60] target/arm: Enable FEAT_CSV3 for -cpu max, Richard Henderson, 2022/04/17
- [PATCH v3 55/60] target/arm: Enable FEAT_CSV2 for -cpu max, Richard Henderson, 2022/04/17
- [PATCH v3 58/60] target/arm: Enable FEAT_DGH for -cpu max, Richard Henderson, 2022/04/17
- [PATCH v3 59/60] target/arm: Define cortex-a76, Richard Henderson, 2022/04/17
- [PATCH v3 60/60] target/arm: Define neoverse-n1, Richard Henderson, 2022/04/17
- Re: [PATCH v3 00/60] target/arm: Cleanups, new features, new cpus, Peter Maydell, 2022/04/22