RE: [PATCH 3/4] hw/block/nvme: supply dw1 for aen result

[Clay Mayers]

> From: Klaus Jensen <its@irrelevant.dk>
> Sent: Thursday, October 20, 2022 10:59 PM
> 
> On Okt 20 17:18, clay.mayers@kioxia.com wrote:
> > From: Clay Mayers <clay.mayers@kioxia.com>
> >
> > cqe.dw1 AEN is sometimes required to convey the NSID of the log page
> > to read.  This is the case for the zone descriptor changed log
> > page.
> >
> > Signed-off-by: Clay Mayers <clay.mayers@kioxia.com>
> > ---
> >  hw/nvme/ctrl.c       | 19 +++++++++++--------
> >  hw/nvme/nvme.h       |  2 ++
> >  hw/nvme/trace-events |  2 +-
> >  include/block/nvme.h |  4 +++-
> >  4 files changed, 17 insertions(+), 10 deletions(-)
> >
> > diff --git a/hw/nvme/nvme.h b/hw/nvme/nvme.h
> > index ae65226150..2b7997e4a7 100644
> > --- a/hw/nvme/nvme.h
> > +++ b/hw/nvme/nvme.h
> > @@ -477,6 +477,8 @@ typedef struct NvmeCtrl {
> >      uint64_t    dbbuf_eis;
> >      bool        dbbuf_enabled;
> >
> > +    bool        zdc_event_queued;
> > +
> >      struct {
> >          MemoryRegion mem;
> >          uint8_t      *buf;
> 
> Looks unrelated to this patch.

Yep - should be in patch 4.

> 
> Otherwise,
> 
> Reviewed-by: Klaus Jensen <k.jensen@samsung.com>