RE: [PATCH 4/4] hw/block/nvme: add zone descriptor changed AEN

[Clay Mayers]

> From: Klaus Jensen <its@irrelevant.dk>
> Sent: Thursday, October 20, 2022 11:41 PM
> 
> On Oct 20 17:18, clay.mayers@kioxia.com wrote:
> > From: Clay Mayers <clay.mayers@kioxia.com>
> >
> > If a namespace's param.zoned.finish_time is non-zero,
> > controllers register with the namespace to be notified
> > when entries are added to its zone-descriptor-changed
> > log page.  If the zone-descriptor-changed aen is enabled,
> > this will cause an AEN to be sent from that controller.
> >
> > Signed-off-by: Clay Mayers <clay.mayers@kioxia.com>
> > ---
> >  hw/nvme/ctrl.c       | 62 +++++++++++++++++++++++++++++++++++++++++++-
> >  hw/nvme/ns.c         |  1 +
> >  hw/nvme/nvme.h       |  9 +++++++
> >  include/block/nvme.h |  2 ++
> >  4 files changed, 73 insertions(+), 1 deletion(-)
> >
> 
> If the controller is hotplugged (device_del'ed), you need to remove the
> controller from the watch list as well. I think in nvme_exit().
> 
> Otherwise, looks good!

Thanks for the quick and useful review.  Adding the watch list was 
a significant design change and I wasn't certain it was in the
spirit of the existing code.  The logic split between ctrl/ns was to
handle shared namespaces as smoothly as possible.