[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 29/30] tests/unit: cleanups for test-io-channel-command
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v4 29/30] tests/unit: cleanups for test-io-channel-command |
Date: |
Mon, 31 Oct 2022 10:24:19 +0000 |
User-agent: |
Mutt/2.2.7 (2022-08-07) |
On Thu, Oct 27, 2022 at 07:36:35PM +0100, Alex Bennée wrote:
> This test is hanging under heavy load when the two socats race while
> trying to create the socket. I've tried various approaches to avoid
> the race but it seems "creat=0" won't stop socat trying to create a
> pipe if it executes first. In the end I just use a small sleep which
> seems to be reliable enough on the load situations I've tried.
>
> While I was there I also properly created a tmpdir for the socket to
> live in which is cleaned up at the end of the test.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Thomas Huth <thuth@redhat.com>
> Cc: Daniel P. Berrangé <berrange@redhat.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Juan Quintela <quintela@redhat.com>
> ---
> tests/unit/test-io-channel-command.c | 45 +++++++++++++++++-----------
> 1 file changed, 28 insertions(+), 17 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
We should figure out a better fix eventually, but this hack at least
ought to avoid the issue for most cases, so worth it as a temp fix.
If I'm nitpicking, I would have preferred the refactoring to be
done separately from the addition of tmpdir, and especially separately
from the sleep, so we can just revert the sleep patch later.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v4 23/30] target/s390x: don't use ld_code2 to probe next pc, (continued)
- [PATCH v4 23/30] target/s390x: don't use ld_code2 to probe next pc, Alex Bennée, 2022/10/27
- [PATCH v4 20/30] tests/avocado: disable sh4 rd2 tests on Gitlab, Alex Bennée, 2022/10/27
- [PATCH v4 15/30] MAINTAINERS: add entries for the key build bits, Alex Bennée, 2022/10/27
- [PATCH v4 18/30] tests/avocado: set -machine none for userfwd and vnc tests, Alex Bennée, 2022/10/27
- [PATCH v4 17/30] MAINTAINERS: fix-up for check-tcg Makefile changes, Alex Bennée, 2022/10/27
- [PATCH v4 28/30] contrib/plugins: protect execlog's last_exec expansion, Alex Bennée, 2022/10/27
- [PATCH v4 25/30] target/s390x: fake instruction loading when handling 'ex', Alex Bennée, 2022/10/27
- [PATCH v4 27/30] contrib/plugins: enable debug on CONFIG_DEBUG_TCG, Alex Bennée, 2022/10/27
- [PATCH v4 29/30] tests/unit: cleanups for test-io-channel-command, Alex Bennée, 2022/10/27
- Re: [PATCH v4 29/30] tests/unit: cleanups for test-io-channel-command,
Daniel P . Berrangé <=
- [PATCH v4 24/30] target/s390x: don't probe next pc for EXecuted insns, Alex Bennée, 2022/10/27
- [PATCH v4 30/30] tests/vm: use -o IdentitiesOnly=yes for ssh, Alex Bennée, 2022/10/27
- [PATCH v4 19/30] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping, Alex Bennée, 2022/10/27