[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC PATCH 27/27] target/arm: don't access TCG code when debugging with
From: |
Fabiano Rosas |
Subject: |
[RFC PATCH 27/27] target/arm: don't access TCG code when debugging with KVM |
Date: |
Wed, 4 Jan 2023 18:58:35 -0300 |
When TCG is disabled this part of the code should not be reachable, so
wrap it with an ifdef for now.
This allows us to start using CONFIG_TCG=n (--disable-tcg in the
configure line).
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
As I understand it, only a small part of the ptw routines should be
necessary for use with KVM+gdbstub. But I don't know enough about arm
MMU yet to make that distinction.
---
target/arm/ptw.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
index f812734bfb..a85eba101f 100644
--- a/target/arm/ptw.c
+++ b/target/arm/ptw.c
@@ -254,6 +254,7 @@ static bool S1_ptw_translate(CPUARMState *env, S1Translate
*ptw,
ptw->out_host = NULL;
ptw->out_rw = false;
} else {
+#ifdef CONFIG_TCG
CPUTLBEntryFull *full;
int flags;
@@ -270,6 +271,9 @@ static bool S1_ptw_translate(CPUARMState *env, S1Translate
*ptw,
ptw->out_rw = full->prot & PAGE_WRITE;
pte_attrs = full->pte_attrs;
pte_secure = full->attrs.secure;
+#else
+ g_assert_not_reached();
+#endif
}
if (regime_is_stage2(s2_mmu_idx)) {
--
2.35.3
- Re: [RFC PATCH 20/27] target/arm: Move cpregs definitions into tcg/cpregs.c, (continued)
- [RFC PATCH 24/27] tests: do not run qom-test on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/04
- [RFC PATCH 26/27] cpu-defs.h: Expose CPUTLBEntryFull to non-TCG code, Fabiano Rosas, 2023/01/04
- [RFC PATCH 21/27] target/arm: make further preparation for the exception code to move, Fabiano Rosas, 2023/01/04
- [RFC PATCH 22/27] target/arm: Move hflags code into the tcg directory, Fabiano Rosas, 2023/01/04
- [RFC PATCH 25/27] tests: device-introspect-test: cope with ARM TCG-only devices, Fabiano Rosas, 2023/01/04
- [RFC PATCH 27/27] target/arm: don't access TCG code when debugging with KVM,
Fabiano Rosas <=
- [RFC PATCH 23/27] tests: do not run test-hmp on all machines for ARM KVM-only, Fabiano Rosas, 2023/01/04