Re: [RFC PATCH 20/27] target/arm: Move cpregs definitions into tcg/cpregs.c

[Richard Henderson]

On 1/4/23 13:58, Fabiano Rosas wrote:
> Code moved verbatim, except for a couple of ifdef CONFIG_TCG that were
> dropped.
>
> Signed-off-by: Fabiano Rosas<farosas@suse.de>
> ---
> Extracted from:
> https://lore.kernel.org/r/20210416162824.25131-15-cfontana@suse.de
> [RFC v14 14/80] target/arm: split cpregs from tcg/helper.c
> ---
>   target/arm/cpu.c               |    1 +
>   target/arm/helper.c            | 8081 -------------------------------
>   target/arm/machine.c           |    1 +
>   target/arm/tcg/cpregs.c        | 8088 ++++++++++++++++++++++++++++++++
>   target/arm/tcg/meson.build     |    1 +
>   target/arm/tcg/op_helper.c     |    1 +
>   target/arm/tcg/translate-a64.c |    1 +
>   target/arm/tcg/translate.c     |    1 +
>   8 files changed, 8094 insertions(+), 8081 deletions(-)
>   create mode 100644 target/arm/tcg/cpregs.c

No, these data structures are used by kvm too, via write_cpustate_to_list -> 
get_arm_cp_reginfo.  The code movement out of helper.c is desired, but the cpregs.c file 
should not be in tcg/.


r~