[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/6] migration: Factor out checks for advised and listenin
From: |
Peter Xu |
Subject: |
Re: [PATCH v3 3/6] migration: Factor out checks for advised and listening incomming postcopy |
Date: |
Thu, 5 Jan 2023 12:18:47 -0500 |
On Thu, Dec 22, 2022 at 12:02:12PM +0100, David Hildenbrand wrote:
> +bool migration_incoming_postcopy_listening(void)
> +{
> + PostcopyState ps = postcopy_state_get();
> +
> + return ps >= POSTCOPY_INCOMING_LISTENING && ps < POSTCOPY_INCOMING_END;
> +}
This name is misleading, IMHO.
The code means "we passed listening phase" but the name implies "we're
listening". We can add the "incoming" into that if we want, though.
--
Peter Xu
- Re: [PATCH v3 3/6] migration: Factor out checks for advised and listening incomming postcopy,
Peter Xu <=