Re: [PATCH v2 11/21] gdbstub: move chunks of user code into own files

[Richard Henderson]

On 1/5/23 08:43, Alex Bennée wrote:
> +static int gdb_signal_table[] = {
> +    -1,
> +    -1,
> +    TARGET_SIGINT,
> +    -1,
> +    -1,
> +    TARGET_SIGTRAP
> +};
> +
> +int gdb_signal_to_target (int sig)
> +{
> +    if (sig < ARRAY_SIZE (gdb_signal_table))
> +        return gdb_signal_table[sig];
> +    else
> +        return -1;
> +}

Code movement, but usually we fix the style issues first.
Also, considering the number of array entries, I'd suggest

    switch (sig) {
    case 2:
        return TARGET_SIGINT;
    case 5:
        return TARGET_SIGTRAP;
    default:
        return -1;
    }


r~