Re: [PATCH v2 13/21] gdbstub: specialise handle_query_attached

[Richard Henderson]

On 1/5/23 08:43, Alex Bennée wrote:
> In both user and softmmu cases we are just replying with a constant.
> If the linker is paying attention it may even be able to sort optimise
> the call.
>
> Signed-off-by: Alex Bennée<alex.bennee@linaro.org>
> ---
>   gdbstub/internals.h |  4 +++-
>   gdbstub/gdbstub.c   | 15 ++-------------
>   gdbstub/softmmu.c   |  5 +++++
>   gdbstub/user.c      |  5 +++++
>   4 files changed, 15 insertions(+), 14 deletions(-)

I'd drop the comment about the linker.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~