Re: [RFC PATCH 16/40] target/arm: Represent the entire MPIDR_EL1

[Richard Henderson]

On 1/6/23 14:14, Peter Maydell wrote:
> +    if (arm_feature(env, ARM_FEATURE_V7MP)) {
> +        cpu->mpidr_el1 |= (1u << 31);   /* M */
> +        if (cpu->core_count == 1) {
> +            cpu->mpidr_el1 |= 1 << 30;  /* U */
> +        }
> +    }
>
> This is wrong, incidentally -- a single Cortex A9, A53, etc does
> not set the U bit. (It's "a cluster with 1 core in it", not
> "a uniprocessor system".)

Hmph.  It would have been handy to have the "uniprocessor" term defined somewhere in the 
architecture manual, since they appear to be using it in a specialized way.


r~