Re: [RFC PATCH 11/40] target/arm: Copy features from ARMCPUClass

[Philippe Mathieu-Daudé]

On 6/1/23 03:19, Richard Henderson wrote:
> On 1/5/23 14:04, Philippe Mathieu-Daudé wrote:
> > On 3/1/23 19:16, Richard Henderson wrote:
> > > Create a features member in ARMCPUClass and copy to the instance in
> > > arm_cpu_init.  Settings of this value will come in a future patch.
> > >
> > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > > ---
> > >   target/arm/cpu-qom.h | 18 ++++++++++++++++++
> > >   target/arm/cpu.c     |  1 +
> > >   2 files changed, 19 insertions(+)


> > > +static inline void unset_class_feature(ARMCPUClass *acc, int feature)
> > > +{
> > > +    acc->features &= ~(1ULL << feature);
> > > +}
> >
> > These helpers are not used until patch #19 "target/arm: Move most cpu
> > initialization to the class".
>
> I know, but I thought it clearer to introduce them with the field.

Fine.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>