Re: [RFC PATCH] tests/tcg: skip the vma-pthread test on CI

[Richard Henderson]

On 1/16/23 07:32, Alex Bennée wrote:
> diff --git a/tests/tcg/multiarch/Makefile.target 
> b/tests/tcg/multiarch/Makefile.target
> index e7213af492..ae8b3d7268 100644
> --- a/tests/tcg/multiarch/Makefile.target
> +++ b/tests/tcg/multiarch/Makefile.target
> @@ -42,6 +42,15 @@ munmap-pthread: LDFLAGS+=-pthread
>   vma-pthread: CFLAGS+=-pthread
>   vma-pthread: LDFLAGS+=-pthread
>   
> +# The vma-pthread seems very sensitive on gitlab and we currently
> +# don't know if its exposing a real bug or the test is flaky.
> +ifneq ($(GITLAB_CI),)
> +run-vma-pthread: vma-pthread
> +       $(call skip-test, $<, "flaky on CI?")
> +run-plugin-vma-pthread-with-%: vma-pthread
> +       $(call skip-test, $<, "flaky on CI?")
> +endif
> +

Ok I guess.  I'd have thought the ifdef around the entire mention of the test would be 
better -- no point in even building it.  But,

Acked-by: Richard Henderson <richard.henderson@linaro.org>


r~