Re: [PATCH v6 14/51] i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode

[David Woodhouse]

On Mon, 2023-01-16 at 17:17 +0000, Paul Durrant wrote:
> ASS(oc); \
> >            optsfn(mc); \
> >            mc->init = initfn; \
> > +        mc->kvm_type = pc_machine_kvm_type; \
> 
> Given that it does nothing in the non-Xen-emulate case, would it not be 
> neater to simply wrap the above line, and the definition of the 
> function, in #ifdef CONFIG_XEN_EMU?

I did it that way first, but you just end up with *more* ifdefs that way.

I'll fix up what looks like a stray tab vs. space issue though; I
thought I ran it all through checkpatch and fixed that kind of thing.

smime.p7s
Description: S/MIME cryptographic signature