Re: [RFC PATCH v3 12/28] target/arm: Wrap arm_rebuild_hflags calls with tcg_enabled

[Fabiano Rosas]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 13/1/23 15:04, Fabiano Rosas wrote:
>> This is in preparation to moving the hflags code into its own file
>> under the tcg/ directory.
>> 
>> Signed-off-by: Fabiano Rosas <farosas@suse.de>
>> ---
>> I extracted these into a separate patch so we can discuss. If I move
>> the tcg_enabled check to a header that would add overhead for all the
>> calls where we know for sure that the code is running with TCG. And I
>> don't think we want a new arm_rebuild_hflags_foo to be used for common
>> code.
>> ---
>>   hw/arm/boot.c             |  6 +++++-
>>   hw/intc/armv7m_nvic.c     | 20 +++++++++++++-------
>>   target/arm/arm-powerctl.c |  7 +++++--
>>   target/arm/cpregs.c       |  2 +-
>>   target/arm/cpu.c          |  3 ++-
>>   target/arm/helper.c       | 16 ++++++++++++----
>>   target/arm/machine.c      |  5 ++++-
>>   7 files changed, 42 insertions(+), 17 deletions(-)
>
> Shouldn't we also restrict arm_rebuild_hflags() to CONFIG_TCG in
> target/arm/cpu.h (to be sure future code using this helper stays
> TCG-only)?

We could, but in practice hflags.c is already under CONFIG_TCG
anyway. If people don't build with disable-tcg they will not notice.