[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 20/27] tests/qtest/vnc-display-test: Disable on Darwin
From: |
Thomas Huth |
Subject: |
[PULL 20/27] tests/qtest/vnc-display-test: Disable on Darwin |
Date: |
Tue, 31 Jan 2023 11:11:58 +0100 |
From: Philippe Mathieu-Daudé <philmd@linaro.org>
This test is failing in gtk-vnc on Darwin:
$ make check-qtest-aarch64
...
19/20 qemu:qtest+qtest-aarch64 / qtest-aarch64/vnc-display-test
ERROR **: 10:42:35.488: vnc-error: Unsupported auth type 17973672
While QEMU picks the sigaltstack coroutine backend, gtk-vnc uses
the ucontext coroutine backend, which might be broken on Darwin.
Disable this test (current problem being investigated in this thread:
Y8kw6X6keB5l53nl@redhat.com/">https://lore.kernel.org/qemu-devel/Y8kw6X6keB5l53nl@redhat.com/).
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20230119120514.28778-4-philmd@linaro.org>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
tests/qtest/vnc-display-test.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/vnc-display-test.c b/tests/qtest/vnc-display-test.c
index df468c7b22..e52a4326ec 100644
--- a/tests/qtest/vnc-display-test.c
+++ b/tests/qtest/vnc-display-test.c
@@ -19,7 +19,7 @@ typedef struct Test {
GMainLoop *loop;
} Test;
-#if !defined(WIN32)
+#if !defined(WIN32) && !defined(CONFIG_DARWIN)
static void on_vnc_error(VncConnection* self,
const char* msg)
@@ -41,6 +41,9 @@ test_setup(Test *test)
#ifdef WIN32
g_test_skip("Not supported on Windows yet");
return false;
+#elif defined(CONFIG_DARWIN)
+ g_test_skip("Broken on Darwin");
+ return false;
#else
int pair[2];
--
2.31.1
- [PULL 01/27] tests/qtest: netdev: test stream and dgram backends, (continued)
- [PULL 01/27] tests/qtest: netdev: test stream and dgram backends, Thomas Huth, 2023/01/31
- [PULL 06/27] travis.yml: Use the libfdt from the distro instead of the submodule, Thomas Huth, 2023/01/31
- [PULL 09/27] qemu/bswap: Replace bswapXX() by compiler __builtin_bswap(), Thomas Huth, 2023/01/31
- [PULL 02/27] tests/qtest/qom-test: Stop spamming the test log, Thomas Huth, 2023/01/31
- [PULL 03/27] tests/qtest/bios-tables-test: Make the test less verbose by default, Thomas Huth, 2023/01/31
- [PULL 05/27] configs/targets/nios2-softmmu: Add TARGET_NEED_FDT=y to the nios2 config, Thomas Huth, 2023/01/31
- [PULL 15/27] MAINTAINERS: Abort HAXM maintenance, Thomas Huth, 2023/01/31
- [PULL 13/27] qemu/bswap: Use compiler __builtin_bswap() on FreeBSD, Thomas Huth, 2023/01/31
- [PULL 17/27] tests/tcg: Do not build/run TCG tests if TCG is disabled, Thomas Huth, 2023/01/31
- [PULL 08/27] tests/docker/dockerfiles: Add libfdt to the i386 and to the riscv64 container, Thomas Huth, 2023/01/31
- [PULL 20/27] tests/qtest/vnc-display-test: Disable on Darwin,
Thomas Huth <=
- [PULL 11/27] qemu/bswap: Remove <byteswap.h> dependency, Thomas Huth, 2023/01/31
- [PULL 14/27] qemu/bswap: Use compiler __builtin_bswap() on NetBSD, Thomas Huth, 2023/01/31
- [PULL 10/27] qemu/bswap: Replace bswapXXs() by compiler __builtin_bswap(), Thomas Huth, 2023/01/31
- [PULL 16/27] docs/about/deprecated: Mark HAXM in QEMU as deprecated, Thomas Huth, 2023/01/31
- [PULL 19/27] tests/qtest/vnc-display-test: Use the 'none' machine, Thomas Huth, 2023/01/31
- [PULL 21/27] tests/qtest/boot-serial-test: Constify tests[] array, Thomas Huth, 2023/01/31
- [PULL 12/27] qemu/bswap: Use compiler __builtin_bswap() on Haiku, Thomas Huth, 2023/01/31
- [PULL 07/27] travis.yml: Remove the generic addons section, Thomas Huth, 2023/01/31
- [PULL 18/27] tests/qtest/vnc-display-test: Suppress build warnings on Windows, Thomas Huth, 2023/01/31
- [PULL 22/27] docs/s390x/pcidevices: document pci devices on s390x, Thomas Huth, 2023/01/31