[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/10] migration: Fix possible race when setting rp_state.
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v3 01/10] migration: Fix possible race when setting rp_state.error |
|
Date: |
Tue, 15 Aug 2023 17:49:34 -0400 |
On Fri, Aug 11, 2023 at 12:08:27PM -0300, Fabiano Rosas wrote:
> We don't need to set the rp_state.error right after a shutdown because
> qemu_file_shutdown() always sets the QEMUFile error, so the return
> path thread would have seen it and set the rp error itself.
>
> Setting the error outside of the thread is also racy because the
> thread could clear it after we set it.
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v3 00/10] Fix segfault on migration return path, Fabiano Rosas, 2023/08/11
- [PATCH v3 01/10] migration: Fix possible race when setting rp_state.error, Fabiano Rosas, 2023/08/11
- Re: [PATCH v3 01/10] migration: Fix possible race when setting rp_state.error,
Peter Xu <=
- [PATCH v3 02/10] migration: Fix possible race when shutting return path, Fabiano Rosas, 2023/08/11
- [PATCH v3 08/10] migration: Move return path cleanup to main migration thread, Fabiano Rosas, 2023/08/11
- [PATCH v3 04/10] migration: Fix possible race when shutting down to_dst_file, Fabiano Rosas, 2023/08/11
- [PATCH v3 07/10] migration: Replace the return path retry logic, Fabiano Rosas, 2023/08/11
- [PATCH v3 03/10] migration: Fix possible race when checking to_dst_file for errors, Fabiano Rosas, 2023/08/11
- [PATCH v3 05/10] migration: Remove redundant cleanup of postcopy_qemufile_src, Fabiano Rosas, 2023/08/11