[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 04/10] migration: Fix possible race when shutting down to_
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH v3 04/10] migration: Fix possible race when shutting down to_dst_file |
|
Date: |
Tue, 15 Aug 2023 17:51:46 -0400 |
On Fri, Aug 11, 2023 at 12:08:30PM -0300, Fabiano Rosas wrote:
> It's not safe to call qemu_file_shutdown() on the to_dst_file without
> first checking for the file's presence under the lock. The cleanup of
> this file happens at postcopy_pause() and migrate_fd_cleanup() which
> are not necessarily running in the same thread as migrate_fd_cancel().
>
> Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
- [PATCH v3 00/10] Fix segfault on migration return path, Fabiano Rosas, 2023/08/11
- [PATCH v3 01/10] migration: Fix possible race when setting rp_state.error, Fabiano Rosas, 2023/08/11
- [PATCH v3 02/10] migration: Fix possible race when shutting return path, Fabiano Rosas, 2023/08/11
- [PATCH v3 08/10] migration: Move return path cleanup to main migration thread, Fabiano Rosas, 2023/08/11
- [PATCH v3 04/10] migration: Fix possible race when shutting down to_dst_file, Fabiano Rosas, 2023/08/11
- Re: [PATCH v3 04/10] migration: Fix possible race when shutting down to_dst_file,
Peter Xu <=
- [PATCH v3 07/10] migration: Replace the return path retry logic, Fabiano Rosas, 2023/08/11
- [PATCH v3 03/10] migration: Fix possible race when checking to_dst_file for errors, Fabiano Rosas, 2023/08/11
- [PATCH v3 05/10] migration: Remove redundant cleanup of postcopy_qemufile_src, Fabiano Rosas, 2023/08/11
- [PATCH v3 06/10] migration: Consolidate return path closing code, Fabiano Rosas, 2023/08/11
- [PATCH v3 09/10] migration: Be consistent about shutdown of source shared files, Fabiano Rosas, 2023/08/11