qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 08/11] target/tricore: Fix RCPW/RRPW_INSERT insns for widt


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 08/11] target/tricore: Fix RCPW/RRPW_INSERT insns for width = 0
Date: Mon, 28 Aug 2023 14:29:40 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0

On 28/8/23 13:26, Bastian Koppelmann wrote:
we would crash if width was 0 for these insns, as tcg_gen_deposit() is
undefined for that case. For TriCore, width = 0 is a mov from the src reg
to the dst reg, so we special case this here.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
---
  target/tricore/translate.c          | 10 ++++++++--
  tests/tcg/tricore/asm/macros.h      | 15 +++++++++++++++
  tests/tcg/tricore/asm/test_insert.S |  9 +++++++++
  3 files changed, 32 insertions(+), 2 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]