[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 18/52] migration/rdma: Fix qemu_rdma_broken_ipv6_kernel() to set
From: |
Markus Armbruster |
Subject: |
[PATCH 18/52] migration/rdma: Fix qemu_rdma_broken_ipv6_kernel() to set error |
Date: |
Mon, 18 Sep 2023 16:41:32 +0200 |
qemu_rdma_resolve_host() and qemu_rdma_dest_init() try addresses until
they find on that works. If none works, they return the first Error
set by qemu_rdma_broken_ipv6_kernel(), or else return a generic one.
qemu_rdma_broken_ipv6_kernel() neglects to set an Error when
ibv_open_device() fails. If a later address fails differently, we use
that Error instead, or else the generic one. Harmless enough, but
needs fixing all the same.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
migration/rdma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/migration/rdma.c b/migration/rdma.c
index be66f53489..08cd186385 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -855,6 +855,8 @@ static int qemu_rdma_broken_ipv6_kernel(struct ibv_context
*verbs, Error **errp)
if (errno == EPERM) {
continue;
} else {
+ error_setg_errno(errp, errno,
+ "could not open RDMA device context");
return -EINVAL;
}
}
--
2.41.0
- [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool, (continued)
- [PATCH 18/52] migration/rdma: Fix qemu_rdma_broken_ipv6_kernel() to set error,
Markus Armbruster <=
- [PATCH 31/52] migration/rdma: Retire macro ERROR(), Markus Armbruster, 2023/09/18
- [PATCH 44/52] migration/rdma: Silence qemu_rdma_resolve_host(), Markus Armbruster, 2023/09/18
- [PATCH 29/52] migration/rdma: Plug a memory leak and improve a message, Markus Armbruster, 2023/09/18
- [PATCH 08/52] migration/rdma: Fix qemu_rdma_accept() to return failure on errors, Markus Armbruster, 2023/09/18