Re: [PATCH 05/52] migration/rdma: Consistently use uint64

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/52] migration/rdma: Consistently use uint64_t for work req

From:	Fabiano Rosas
Subject:	Re: [PATCH 05/52] migration/rdma: Consistently use uint64_t for work request IDs
Date:	Mon, 18 Sep 2023 14:03:21 -0300

Markus Armbruster <armbru@redhat.com> writes:

> We use int instead of uint64_t in a few places.  Change them to
> uint64_t.
>
> This cleans up a comparison of signed qemu_rdma_block_for_wrid()
> parameter @wrid_requested with unsigned @wr_id.  Harmless, because the
> actual arguments are non-negative enumeration constants.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Fabiano Rosas <farosas@suse.de>

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 19/52] migration/rdma: Fix qemu_get_cm_event_timeout() to always set error, (continued)
- [PATCH 33/52] migration/rdma: Drop "@errp is clear" guards around error_setg(), Markus Armbruster, 2023/09/18
  - Re: [PATCH 33/52] migration/rdma: Drop "@errp is clear" guards around error_setg(), Zhijian Li (Fujitsu), 2023/09/25
- [PATCH 10/52] migration/rdma: Eliminate error_propagate(), Markus Armbruster, 2023/09/18
  - Re: [PATCH 10/52] migration/rdma: Eliminate error_propagate(), Fabiano Rosas, 2023/09/18
  - Re: [PATCH 10/52] migration/rdma: Eliminate error_propagate(), Zhijian Li (Fujitsu), 2023/09/21
- [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool, Markus Armbruster, 2023/09/18
  - Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool, Fabiano Rosas, 2023/09/18
  - Re: [PATCH 13/52] migration/rdma: Make qemu_rdma_buffer_mergable() return bool, Zhijian Li (Fujitsu), 2023/09/22
- [PATCH 05/52] migration/rdma: Consistently use uint64_t for work request IDs, Markus Armbruster, 2023/09/18
  - Re: [PATCH 05/52] migration/rdma: Consistently use uint64_t for work request IDs, Fabiano Rosas <=
  - Re: [PATCH 05/52] migration/rdma: Consistently use uint64_t for work request IDs, Zhijian Li (Fujitsu), 2023/09/19
- [PATCH 43/52] migration/rdma: Convert qemu_rdma_alloc_pd_cq() to Error, Markus Armbruster, 2023/09/18
  - Re: [PATCH 43/52] migration/rdma: Convert qemu_rdma_alloc_pd_cq() to Error, Zhijian Li (Fujitsu), 2023/09/26
    - Re: [PATCH 43/52] migration/rdma: Convert qemu_rdma_alloc_pd_cq() to Error, Markus Armbruster, 2023/09/26
    - Re: [PATCH 43/52] migration/rdma: Convert qemu_rdma_alloc_pd_cq() to Error, Zhijian Li (Fujitsu), 2023/09/26
- [PATCH 18/52] migration/rdma: Fix qemu_rdma_broken_ipv6_kernel() to set error, Markus Armbruster, 2023/09/18
  - Re: [PATCH 18/52] migration/rdma: Fix qemu_rdma_broken_ipv6_kernel() to set error, Fabiano Rosas, 2023/09/18
  - Re: [PATCH 18/52] migration/rdma: Fix qemu_rdma_broken_ipv6_kernel() to set error, Zhijian Li (Fujitsu), 2023/09/22
- [PATCH 31/52] migration/rdma: Retire macro ERROR(), Markus Armbruster, 2023/09/18
  - Re: [PATCH 31/52] migration/rdma: Retire macro ERROR(), Zhijian Li (Fujitsu), 2023/09/25

Prev by Date: Re: [PATCH 04/52] migration/rdma: Drop fragile wr_id formatting
Next by Date: Re: [PATCH 06/52] migration/rdma: Clean up two more harmless signed vs. unsigned issues
Previous by thread: [PATCH 05/52] migration/rdma: Consistently use uint64_t for work request IDs
Next by thread: Re: [PATCH 05/52] migration/rdma: Consistently use uint64_t for work request IDs
Index(es):
- Date
- Thread