[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/8] target/sparc: Fix VIS fmul8x16au instruction.
From: |
Nick Bowler |
Subject: |
Re: [PATCH 2/8] target/sparc: Fix VIS fmul8x16au instruction. |
Date: |
Thu, 28 Sep 2023 20:41:13 -0400 |
On 2023-09-28, Richard Henderson <richard.henderson@linaro.org> wrote:
> Belated follow-up suggestion:
>
> - if ((tmp & 0xff) > 0x7f) {
> - tmp += 0x100;
> - }
> + tmp += 0x80;
>
> 7 occurrences throughout vis_helper.c.
I agree with making this particular change but I think since it doesn't
fix a bug, it should go in a separate patch.
So I will include a patch to do that in series v2 and keep this one
as-is with your Reviewed-by.
Thanks,
Nick
- [PATCH 6/8] target/sparc: Fix VIS fpmerge input registers., (continued)
- [PATCH 5/8] target/sparc: Fix VIS fmuld8ulx16 instruction., Nick Bowler, 2023/09/25
- [PATCH 3/8] target/sparc: Fix VIS fmul8x16al instruction., Nick Bowler, 2023/09/25
- [PATCH 1/8] target/sparc: Fix VIS fmul8x16 input register., Nick Bowler, 2023/09/25
- [PATCH 7/8] target/sparc: Fix VIS fexpand input register., Nick Bowler, 2023/09/25
- Re: [PATCH 0/8] SPARC VIS fixes, Mark Cave-Ayland, 2023/09/28