[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES

From: Richard Henderson
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions
Date: Mon, 24 Feb 2014 10:22:21 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

On 02/24/2014 10:11 AM, Peter Maydell wrote:
> On 24 February 2014 17:59, Richard Henderson <address@hidden> wrote:
>> I'll also note that arm contains a second copy of the aes_{i,}shifts arrays.
>> So after those are moved to common code, we avoid that duplication too.
> AIUI this duplication was because the utils/ code wasn't suitable
> for ARM; Ard's rationale is here:
> http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg01789.html

That's about sbox vs AES_Te*.

In the bit you quote, I'm talking about aes_shift[] vs shift[0][] and
aes_ishift[] vs shift[1][], in the i386 and arm backends respectively.  And
arguing that data should be moved to utils/ so that it can be shared between
i386, arm, and ppc.

In a bit you don't quote, I argue that arm's sbox array should be moved to
utils/ so that it can be shared with ppc, which will need it for its "vsbox"

I don't really have an opinion on arm's MixColumns lookup table.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]