[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES
From: |
Richard Henderson |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions |
Date: |
Mon, 24 Feb 2014 10:22:21 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 |
On 02/24/2014 10:11 AM, Peter Maydell wrote:
> On 24 February 2014 17:59, Richard Henderson <address@hidden> wrote:
>> I'll also note that arm contains a second copy of the aes_{i,}shifts arrays.
>> So after those are moved to common code, we avoid that duplication too.
>
> AIUI this duplication was because the utils/ code wasn't suitable
> for ARM; Ard's rationale is here:
> http://lists.gnu.org/archive/html/qemu-devel/2013-12/msg01789.html
That's about sbox vs AES_Te*.
In the bit you quote, I'm talking about aes_shift[] vs shift[0][] and
aes_ishift[] vs shift[1][], in the i386 and arm backends respectively. And
arguing that data should be moved to utils/ so that it can be shared between
i386, arm, and ppc.
In a bit you don't quote, I argue that arm's sbox array should be moved to
utils/ so that it can be shared with ppc, which will need it for its "vsbox"
instruction.
I don't really have an opinion on arm's MixColumns lookup table.
r~
- [Qemu-ppc] [PATCH 21/28] target-ppc: Altivec 2.07: vbpermq Instruction, (continued)
- [Qemu-ppc] [PATCH 21/28] target-ppc: Altivec 2.07: vbpermq Instruction, Tom Musta, 2014/02/12
- [Qemu-ppc] [PATCH 22/28] target-ppc: Altivec 2.07: Doubleword Compares, Tom Musta, 2014/02/12
- [Qemu-ppc] [PATCH 23/28] target-ppc: Altivec 2.07: Vector Gather Bits by Bytes, Tom Musta, 2014/02/12
- [Qemu-ppc] [PATCH 24/28] target-ppc: Altivec 2.07: Vector Polynomial Multiply Sum, Tom Musta, 2014/02/12
- [Qemu-ppc] [PATCH 25/28] target-ppc: Altivec 2.07: Binary Coded Decimal Instructions, Tom Musta, 2014/02/12
- [Qemu-ppc] [PATCH 26/28] target-ppc: Altivec 2.07: AES Instructions, Tom Musta, 2014/02/12
[Qemu-ppc] [PATCH 27/28] target-ppc: Altivec 2.07: Vector SHA Sigma Instructions, Tom Musta, 2014/02/12
[Qemu-ppc] [PATCH 28/28] target-ppc: Altivec 2.07: Vector Permute and Exclusive OR, Tom Musta, 2014/02/12
[Qemu-ppc] [PATCH 19/28] target-ppc: Altivec 2.07: Vector Doubleword Rotate and Shift Instructions, Tom Musta, 2014/02/12
[Qemu-ppc] [PATCH 18/28] target-ppc: Altivec 2.07: Change Bit Masks to Support 64-bit Rotates and Shifts, Tom Musta, 2014/02/12
Re: [Qemu-ppc] [Qemu-devel] [PATCH 00/28] target-ppc: Altivec 2.07, Richard W.M. Jones, 2014/02/18